fix(material/chips): add only active autocomplete option on selection #32208
+44
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lekhmanrus
requested review from
andrewseguin and
wagnermaciel
and removed request for
a team
lekhmanrus
force-pushed
the
fix/32204/material-chips-add-only-active-autocomplete-option-on-selection
branch
from
54f3573 to
372d20b
Compare
crisbeto
reviewed
Oct 30, 2025
| selector: 'input[matChipInputFor][matAutocomplete]', | ||
| exportAs: 'matChipInput, matChipInputFor', | ||
| }) | ||
| export class MatChipAutocompleteInput extends MatChipInput { |
There was a problem hiding this comment.
This will be breaking for apps using standalone. Also I'm not sure it's the way to go since it means that apps which use chips will have to load the autocomplete too.
Couldn't we resolve it by adjusting the demo?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using MatChipInput with MatAutocomplete, pressing Enter after typing and selecting an autocomplete option caused two chips to be added - one from the typed text and one from the selected option.
This behavior did not occur when selecting with a mouse click.
This PR updates the chips input handling logic to ensure that only the selected autocomplete option is added when the user confirms the selection.
close #32204, #13574