Skip to content

Fix devcontainer setup #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix devcontainer setup #68

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c55ab9f
Fix devcontainer setup
phxnsharp May 20, 2024
461c725
Merge branch 'main' into maint/devcontainer
phxnsharp Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .devcontainer/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
{
"name": "Python 3",
// Or use a Dockerfile or Docker Compose file. More info: https://containers.dev/guide/dockerfile
"image": "mcr.microsoft.com/devcontainers/python:0-3.8",
"image": "mcr.microsoft.com/devcontainers/python:0-3.9",
"customizations": {
"vscode": {
"extensions": [
Expand All @@ -17,7 +17,7 @@
"ghcr.io/devcontainers-contrib/features/poetry:2": {
"version": "latest"
}
},
}

// Use 'forwardPorts' to make a list of ports inside the container available locally.
// "forwardPorts": [],
Expand All @@ -27,7 +27,6 @@
// file is copied in, preventing access to ansys-common-variableinterop for me. This
// has the side-effect of running it every time you start the container, which
// might not be what we want?
"postStartCommand": "git config --list && poetry -vv install -E dev"

// Uncomment to connect as root instead. More info: https://aka.ms/dev-containers-non-root.
// "remoteUser": "root"
Expand Down
Loading