-
Notifications
You must be signed in to change notification settings - Fork 389
Add support for UV dependency management #2601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Fokko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great @geruh, I hear a lot of good stuff around uv 🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this!
I tested a few things locally.
- all the
makecommand - side by side pyproject.toml comparison
- ran a few github workflows on my forked repo
python-ci.yml✅python-ci-docs.yml✅nightly-pypi-build.yml❌ (something weird with cibuildwheel)
We might want to rebase this PR to capture of of the recent changes, such as the 3.9 deprecation. I'm not too worried about the library versioning since the dependabot workflow will upgrade them again
btw, there are a still references to poetry in mkdocs/docs/contributing.md
|
i cant seem to get |
kevinjqliu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generally lgtm.
i tested the github workflow changes on my fork
.github/workflows/nightly-pypi-build.yml
.github/workflows/python-release.yml
.github/workflows/pypi-build-artifacts.yml
.github/workflows/svn-build-artifacts.yml
.github/workflows/python-ci.yml
.github/workflows/python-ci-docs.yml
.github/workflows/python-release-docs.yml
Closes #2553
Rationale for this change
During the release process cleanup, I also had prototyped a migration from Poetry to UV. I used the https://github.com/mkniewallner/migrate-to-uv package to migrate to UV and ran a release workflow and some others like doc serve for validation.
This PR also migrates the Makefile to use UV. I'll still need to upgrade the docs to reflect the UV contribution workflow. I think it would be a good start to push up as a prototype, and have others checkout and give it a try.
Build System Changes
Build Backend
UV doesn't have a Poetry-equivalent build backend with build hooks, so I've switched to setuptools with native Cython support for the avro changes.
Packaging for release
PEP 639 License Compliance
By going to the test above the license is now properly included in the release metadata
Build Verification
Release builds verified:
Wheel vs Poetry:
.sofile per wheel (not "fat" wheels with all Python versions)dist-info/licenses/(PEP 639)Are these changes tested?
Yes
make installEnvironment setup and dependency installationmake test- Unit testsmake test-integration- Integration tests with all extrasmake lint- Linting and code quality checksmake doc-install && make doc-serve- DocumentationAre there any user-facing changes?
No user facing changes. Contributors will need to use UV instead of Poetry for development, but all make targets remain the same. So not really?