[SPARK-54060][Geo][SQL] Introduce Geometry and Geography in-memory wrapper formats #52761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uros-db
commented
Oct 28, 2025
cloud-fan
approved these changes
Oct 29, 2025
|
thanks, merging to master! |
|
@uros-db and @cloud-fan . The PR seems to have a wrong JIRA ID.
|
cloud-fan
changed the title
|
Thank you @dongjoon-hyun @cloud-fan. |
|
sorry I was too careless... reopened the SPIP JIRA ticket and closed the actual ticket. |
|
Thank you for correcting. :) |
Yicong-Huang
pushed a commit
to Yicong-Huang/spark
that referenced
this pull request
Oct 30, 2025
…apper formats ### What changes were proposed in this pull request? Introduce the catalyst-internal geospatial in-memory layout for Geometry and Geography: `SRID` (integer value) header + `WKB` (byte array) payload, and add core conversion API to retrieve these values from the server-side execution wrappers. ### Why are the changes needed? Establish a consistent representation/encoding for geospatial types, with a clear contract towards `Geometry` and `Geography` classes. This also provides minimal safe SRID & WKB extraction in execution and lays the groundwork for standard format support, conversions, etc. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Added the appropriate unit tests to validate SRID and WKB extraction from the in-memory data formats: - `GeographyExecutionSuite` - `GeometryExecutionSuite` ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#52761 from uros-db/geo-memory-repr. Authored-by: Uros Bojanic <uros.bojanic@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Introduce the catalyst-internal geospatial in-memory layout for Geometry and Geography:
SRID(integer value) header +WKB(byte array) payload, and add core conversion API to retrieve these values from the server-side execution wrappers.Why are the changes needed?
Establish a consistent representation/encoding for geospatial types, with a clear contract towards
GeometryandGeographyclasses. This also provides minimal safe SRID & WKB extraction in execution and lays the groundwork for standard format support, conversions, etc.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Added the appropriate unit tests to validate SRID and WKB extraction from the in-memory data formats:
GeographyExecutionSuiteGeometryExecutionSuiteWas this patch authored or co-authored using generative AI tooling?
No.