fixes #132 by allowing to pass dates as string instead of instant for… #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrections, no semi-colons in python, please
add oms directory
* support for reconnecting has been added * Update pom.xml Co-authored-by: Artur Pietrzyk <Svisstack@users.noreply.github.com>
…nstant for the java sdk because instant.now() might have higher precision the 7 on jdk > 8
|
there is no way to force object to produce string with correct number of digits in the precision? |
|
there is, but it's not very flexible - since there are a lot of possible formats: https://docs.coinapi.io/#time i would leave this to the user - especially to reduce errors like this one, where a change in the JDK changes the behaviour of the application |
Svisstack
force-pushed
the
master
branch
2 times, most recently
from
819b4fc to
ded59d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… the java sdk because instant.now() might have higher precision the 7 on jdk > 8