feat(symfony): allow symfony makers namespace configuration #7497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esserj
commented
Oct 31, 2025
| $services = $container->services(); | ||
|
|
||
| $services->set('api_platform.maker.command.state_processor', 'ApiPlatform\Symfony\Maker\MakeStateProcessor') | ||
| ->args([service('api_platform.metadata.resource.name_collection_factory')]) |
There was a problem hiding this comment.
service('api_platform.metadata.resource.name_collection_factory') was introduced in the original PR
But there was no dependency on this class then, or is now, so I'm assuming this was a leftover from an earlier approach
esserj
force-pushed
the
configurable-maker-paths
branch
3 times, most recently
from
c0c31ee to
2db31bb
Compare
esserj
changed the title
esserj
force-pushed
the
configurable-maker-paths
branch
2 times, most recently
from
4306e7b to
8eec7c8
Compare
|
Nice thanks, could you run cs and fix your commit ? thanks! |
esserj
force-pushed
the
configurable-maker-paths
branch
from
8eec7c8 to
a4530c0
Compare
|
Done |
esserj
force-pushed
the
configurable-maker-paths
branch
from
a4530c0 to
0f75ef8
Compare
esserj
changed the title
esserj
force-pushed
the
configurable-maker-paths
branch
from
0f75ef8 to
419e021
Compare
|
These other CI failures seem to be unrelated (at least one has an outsanding PR with a fix) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can now configure the base namespace prefix for all makers but also add a command line option in case you want to customize the namespace even further
This allows developers to organize all api code into a single namespace/directory
Example
will cause all generated classes to be created in
src/ApiCli Example
bin/console make:state-provider --namespace-prefix Api\\StateProviderwill cause the generated provider to be created in
src/Api/StateProviderthe same applies to the processor and filter maker