-
Notifications
You must be signed in to change notification settings - Fork 88
feat: added lazy and suspense with skeleton on various folders #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Shivam107
wants to merge
10
commits into
apsinghdev:main
Choose a base branch
from
Shivam107:fix/lazyAndSuspense
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
b1986a2
updated faq for lazyAndSuspense
Shivam107 cb476f1
orignal yaml files
Shivam107 3583541
Update prisma and @prisma/client versions
Shivam107 9986690
Modify Account table structure in migration.sql
Shivam107 e2166cf
Delete apps/api/prisma/migrations/migration_lock.toml
Shivam107 2b2fd03
Delete apps/api/prisma/migrations/20251014050423_init/migration.sql
Shivam107 6dc8a40
fix: remove dashboard skeleton fallbacks
Shivam107 d4f67b3
Merge branch 'apsinghdev:main' into fix/lazyAndSuspense
Shivam107 9044df4
Merge branch 'main' into fix/lazyAndSuspense
Shivam107 ba27938
Merge branch 'main' into fix/lazyAndSuspense
Shivam107 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,31 @@ | ||
| import Navbar from '@/components/landing-sections/navbar' | ||
| import React from 'react' | ||
| "use client"; | ||
|
|
||
| import React, { Suspense, lazy } from "react"; | ||
|
|
||
| import { Skeleton } from "@/components/ui/skeleton"; | ||
|
|
||
| const Navbar = lazy(() => import("@/components/landing-sections/navbar")); | ||
|
|
||
| const Layout = ({ children }: { children: React.ReactNode }) => { | ||
| return ( | ||
| <section> | ||
| <Navbar /> | ||
| {children} | ||
| </section> | ||
| ) | ||
| } | ||
|
|
||
| export default Layout | ||
| return ( | ||
| <section> | ||
| <Suspense | ||
| fallback={ | ||
| <div className="py-20 text-center text-lg text-neutral-400"> | ||
| <div className="mx-auto flex w-full max-w-md flex-col items-center gap-4 px-6"> | ||
| <Skeleton className="h-6 w-40" /> | ||
| <Skeleton className="h-4 w-72" /> | ||
| <Skeleton className="h-4 w-64" /> | ||
| <Skeleton className="h-4 w-56" /> | ||
| </div> | ||
| </div> | ||
| } | ||
| > | ||
| <Navbar /> | ||
| </Suspense> | ||
| {children} | ||
| </section> | ||
| ); | ||
| }; | ||
|
|
||
| export default Layout; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.