Skip to content

Conversation

@cmaglie
Copy link
Member

@cmaglie cmaglie commented Oct 3, 2025

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

This is an extract of #2917 containing only the gRPC part of the PR.

What is the current behavior?

Adds only the gRPC functions for managing libraries in profiles, no user-facing changes.

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

No

Other information

@cmaglie cmaglie self-assigned this Oct 3, 2025
@cmaglie cmaglie added type: enhancement Proposed improvement topic: gRPC Related to the gRPC interface labels Oct 3, 2025
@per1234 per1234 added the topic: code Related to content of the project itself label Oct 4, 2025
per1234
per1234 previously requested changes Oct 5, 2025
@codecov
Copy link

codecov bot commented Oct 6, 2025

Codecov Report

❌ Patch coverage is 18.41004% with 390 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.34%. Comparing base (a8423ab) to head (0c28634).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
commands/service_profile_lib_add.go 0.00% 104 Missing ⚠️
internal/arduino/sketch/profiles.go 18.03% 91 Missing and 9 partials ⚠️
commands/service_profile_init.go 0.00% 59 Missing ⚠️
commands/service_profile_lib_remove.go 0.00% 33 Missing ⚠️
commands/instances.go 0.00% 25 Missing and 1 partial ⚠️
commands/service_profile_lib_list.go 0.00% 20 Missing ⚠️
commands/service_profile_set_default.go 0.00% 19 Missing ⚠️
commands/cmderrors/cmderrors.go 0.00% 10 Missing and 1 partial ⚠️
...rnal/arduino/libraries/librariesmanager/install.go 65.21% 7 Missing and 1 partial ⚠️
commands/service_library_install.go 56.25% 5 Missing and 2 partials ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3019      +/-   ##
==========================================
- Coverage   68.39%   67.34%   -1.06%     
==========================================
  Files         241      246       +5     
  Lines       22734    23137     +403     
==========================================
+ Hits        15550    15582      +32     
- Misses       5988     6350     +362     
- Partials     1196     1205       +9     
Flag Coverage Δ
unit 67.34% <18.41%> (-1.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

As stated by @per1234:

> Build profile data is already provided via the LoadSketch method, so it
> seems that even a mechanism that is truly for getting profile data should
> be implemented by simply expanding the SketchProfile message to contain
> all the data of the build profile (actually kind of silly that it
> currently only provides a subset of the profile data).

arduino#3019 (comment)
@per1234 per1234 dismissed their stale review October 6, 2025 13:17

Requested change has been made. Thanks!

// Name of the library.
string name = 1;
// Version of the library if taken from the Library Index.
string version = 2;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clients would love to use a dedicated message to add the latest version of the library (without listing the available versions), and maybe add the currently installed version that errors if the library is not installed.

@cmaglie cmaglie force-pushed the grpc-profiles-functions branch from dbac430 to 2327b35 Compare October 29, 2025 10:00
@dankeboy36
Copy link
Contributor

Hello Cristian,

Thanks for your great work 💪 I’ve been testing this area from the IDE side and was wondering how this feature is expected to work with an IDE or editor. Maybe this isn’t the most appropriate channel, but I guess you’re the best person to ask.

It’s clear there’s a real need for this feature:

While reading the PR and the related IDE issue arduino/arduino-ide#2573, I was trying to understand how profiles are meant to behave over gRPC, maybe later in Arduino IDE 2.x:

  • If an IDE opens two sketches with different profiles (e.g. arduino:avr:uno and esp32:esp32:esp32da), should each sketch have its own gRPC client or session?
  • When switching or activating a profile, does the CLI reinitialize the build environment (toolchains, platforms, libraries), or are these shared and cached? For example, if libA is installed in profileA but not in profileB, will a library search over gRPC return different results for each profile?
  • If multiple profiles use the same library, will it be installed multiple times, or can they share a global copy? Since each sketch can have its own sketch.yaml, does that mean the same dependency could be downloaded many times?
  • When using gRPC, should compile, upload, etc. always load fqbn, port, and other settings from the active profile, or should clients omit them?

I really like how profiles make builds reproducible and easy to share — that’s perfect for CI or collaborative work. But in an IDE that uses gRPC interactively, managing multiple isolated clients could get heavy, especially if it means repeated downloads.

In my current setup I treat sketch.yaml mostly as a lightweight config file. Libraries and platforms are managed globally, and if something is missing, the user only gets a warning instead of full profile enforcement.

I’d be curious to hear how Arduino sees this working long-term on the gRPC side — especially for IDE integration. Will profiles act more like isolated environments or just as stored build settings that can be written and updated through gRPC?

No hurry with this. Thanks a lot for your time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: code Related to content of the project itself topic: gRPC Related to the gRPC interface type: enhancement Proposed improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants