ODroidM1: add BOOTFS_TYPE=ext4 into board config to fix after #8751

[iav]

After #8751 ODroid-M1 not boots.
With this string it boots again.

How Has This Been Tested?

Build image for ODroid-M1 with root on btrfs without patch. System not boots from image.
Build image for ODroid-M1 with root on btrfs with patch. System boots from image.

Checklist:

• My changes generate no new warnings
• Any dependent changes have been merged and published in downstream modules

[coderabbitai]

Walkthrough

Added a new board configuration variable BOOTFS_TYPE="ext4" in config/boards/odroidm1.conf. Modified boot partition creation logic in lib/functions/image/partitioning.sh: a boot partition is now created when BOOTSIZE != "0" and either BOOTFS_TYPE != ROOTFS_TYPE or BOOTPART_REQUIRED == "yes" (previously the condition checked for presence/non-empty BOOTFS_TYPE instead of comparing it to ROOTFS_TYPE). No other functional or control-flow changes detected.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

• Verify naming consistency and expected default value in config/boards/odroidm1.conf.
• Check the new conditional in lib/functions/image/partitioning.sh for edge cases (empty or unset BOOTFS_TYPE/ROOTFS_TYPE) and correct quoting/word-splitting in shell.
• Search for other code or docs that relied on the previous presence-check behavior for BOOTFS_TYPE.
• Confirm interactions with BOOTPART_REQUIRED and any callers that set it.

Possibly related PRs

• allow building a minimal btrfs compressed image #8751 — modifies lib/functions/image/partitioning.sh boot-partition creation logic in a closely related way.

Suggested reviewers

• chraac
• igorpecovnik
• amazingfate
• catalinii

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title "ODroidM1: add BOOTFS_TYPE=ext4 into board config to fix after #8751" directly and accurately describes the primary change in the pull request. The raw summary confirms that the main modification is adding the BOOTFS_TYPE variable with value "ext4" to the ODroid-M1 board configuration file. The title is concise, specific, and clearly communicates both what was changed and why (fixing a regression from PR #8751). The title is fully related to the main change in the changeset.
Description Check	✅ Passed	The pull request description is related to the changeset and provides relevant context. It explains that the change fixes an ODroid-M1 boot regression introduced by PR #8751, describes the testing performed (building with and without the patch on btrfs root), and confirms that no new warnings were generated. While the description is brief, it clearly communicates the purpose and validation of the changes rather than being vague or completely off-topic.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 121b463 and d313443.

📒 Files selected for processing (1)

• lib/functions/image/partitioning.sh (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• lib/functions/image/partitioning.sh

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

✅ This PR has been reviewed and approved — all set for merge!

[rpardini]

This looks like it's forcing a separate /boot partition to address the btrfs case.
Simple builds with full-ext4 shouldn't need it.
I'd fix whatever is broken with the btrfs instead of crippling ext4 rootfs.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 22a8ffd and 121b463.

📒 Files selected for processing (1)

• lib/functions/image/partitioning.sh (1 hunks)

🧰 Additional context used

🧬 Code graph analysis (1)

lib/functions/image/partitioning.sh (1)

extensions/cloud-init/cloud-init.sh (1)

• extension_prepare_config__ci_compatibility_check (30-40)

🪛 GitHub Actions: Shellcheck - PR #8829 ("ODroidM1: add BOOTFS_TYPE=ext4 into board config to fix after #8751")

lib/functions/image/partitioning.sh

[error] 116-116: ShellCheck SC2053: Quote the right-hand side of != in [[ ]] to prevent glob matching. (lib/ code detected as critical; exit code 1)

[amazingfate]

What about the condition that user just want a seperate boot partition with same filesystem type as root? There are other declarations like BOOTFS_TYPE="ext4" in config/boards.

[iav]

User just want a separate boot partition with same filesystem can use BOOTPART_REQUIRED == "yes".
Other declarations like BOOTFS_TYPE="ext4" in config/boards will work, I suppose.
BOOTFS_TYPE I test, it works. If you worries about other declarations — just say, will think about it.

BOOTFS_TYPE have to be filled in boadrconfigs for boards that can boot only from ext4 or fat fs.

[iav]

I would like to remind you that sometimes, albeit rarely, not only ext4 and btrfs fs are used.