[flynt] Fix static-join-to-f-string when mixing raw and non-raw strings (FLY002)
#21087
+255
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix FLY002 to bail on transformations when mixing raw and non-raw strings. Mixing them can cause syntax errors, null bytes, or incorrect carriage-return behavior.
Closes #21082
Problem Analysis
When the first string in a join is raw (
r"") and later strings are not:"".join((r"", '"'))→r""")"".join((r"", "\0")))Approach
Added a check in
build_fstringto verify all strings have the same raw status. If not, the transformation is skipped:Noneearly if raw statuses differTesting
Added tests covering:
nok14-nok18: Mixed raw/non-raw (not transformed)ok7,ok8: All raw (transformed)ok9,ok10: All non-raw (transformed)Ran with problematic examples from the issue; transformations are skipped as expected.