Skip to content

Exclude test dependencies from production Atom binary #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Exclude test dependencies from production Atom binary #302

wants to merge 4 commits into from

Conversation

@aminya
Copy link
Member

@aminya aminya commented Apr 1, 2021

Description

This excludes the test dependencies from the production Atom binary. This is done by moving those dependencies to spec folder.

Benefits

  • The production Atom binary will be smaller and load faster
  • This removes the security issues involved with these old dependencies in the final Atom binary

Drawbacks

N/A

@aminya aminya added dependencies Pull requests that update a dependency file medium-priority performance labels Apr 1, 2021
@aminya aminya closed this Jul 22, 2021
@aminya aminya closed this Jul 22, 2021
@aminya aminya reopened this Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file medium-priority performance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aminya