Fix for issue #16 #18
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@HeikoNitrobox Thank you for the PR - I will need to fix this in the core generator as the API file is generated each time we publish, so the changes will be overwritten. We will digest this and get it addressed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
I've fixed Issue#16.
If an Accept header is provided for document downloads, it will now be used; otherwise, it defaults to application/json.
I also migrated the existing tests to JUnit 5 and added new tests for this issue using WireMock.
Unfortunately, I wasn’t able to run the existing unit tests due to a missing .env file for Dotenv.
If possible, it would be great if you could add that file to the project.
Thanks!