Skip to content

Fix Endpoint Ready Sync Issue via Update Trigger #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 163 commits into
base: main
Choose a base branch
from
Open

Fix Endpoint Ready Sync Issue via Update Trigger #327

wants to merge 163 commits into from

Conversation

@jungrae-prestolabs
Copy link

Reproduction:

In endpointslice which gen by serviceImport

  1. Forcefully set conditions.ready to false.
  2. Even if the desired endpoint’s conditions.ready is true, it does not sync well

Deploy Scenario:

  1. During a rolling update of components (which has serviceExport), if the new endpoint does not pass the health check immediately, the MCS controller's fetch process publishes the endpoint to Cloudmap with ready: false.
  2. If the edge cluster fetches at that moment, it receives the status as ready: false.
  3. Subsequently, even if the actual state changes to ready: true, the ready status remains unsynced.

Solution:

Introduce a flag that triggers an update by setting ready to true whenever the existing state differs from the desired state.

astaticvoid and others added 30 commits October 8, 2021 14:02
@astaticvoid
Revert kubetest2 integration (aws#17)
2158517 
Remove kubetest2 integration in favour of exploring another e2e framework.

* Revert "Update test export API version (aws#12)"

This reverts commit 50cf0a1.

* Revert "Create end to end testing deployment (aws#9)"

This reverts commit b5fa92a.

* Revert "Add kubetest2-kind for end to end testing (aws#8)"

This reverts commit e0d0ea7.
Add instructions to install from latest (aws#27)
205c162
@runakash
Integrate Github's Codql Analysis (aws#28)
46c4d4f
@runakash
Add first version to the changelog (aws#30)
5e43764
Add ability to install from release version + doc updates (aws#29)
9379044 
* Add instructions for installing from release

* Development and instllation updates

* more updates

* add more quotes

* Add usage section
@vanekjar
Update README.md badges (Godoc link) (aws#32)
e747596
@vanekjar
Integrate Codecov to publish code coverage data (aws#33)
1727fe7
@vanekjar
Fix instance port conversion to be CPU arch independent (aws#35)
1298c5d
@thalleslmF @thallesfreitaszup
Create namespace when it does not exist (aws#25)
ed85cdf 
Create http namespace in Cloud Map if necessary when creating a service.
Co-authored-by: thalles <thalles.freitas@zup.com.br>
@astaticvoid
Modularize Cloud Map client (aws#31)
7e2c176 
Encapsulate Cloud map client logic into modular and maintainable interfaces.

AWS facade provides minimal SDK API surface to facilitate mocking.
Service discovery API acts as a thin wrapper to handle conversion of SD request/response data structures.
Operation poller simplifies logic to monitor multiple inflight operation status.
Operation collector asynchronously collects operations to poll.
Client and Endpoint Manager have been unified due to simplified design gains following above.
@vanekjar
Add unit tests for model package (aws#38)
5c7b033
@astaticvoid
Improve operation collector logic (aws#39)
bdcf3d0 
Encapsulate go routine management during operation collection.
Leverage wait groups and channel lifecycles to simplify collector interface.
Track start time in collector to simplify state management for operation poller.
Add unit tests for operation collector.
@astaticvoid
Add operation poller unit tests (aws#40)
0ad6491
@astaticvoid
Update controller and k8s client versions (aws#42)
f29486f
@astaticvoid
Fix ns id cache (aws#43)
634ffa6 
Stop cacheing empty namespace ID if found in Cloud Map, and cache all namespaces in account.
Continue to cache empty ID if not found to prevent throttling for non-imported services.
@astaticvoid
Refactor client interface for service structs (aws#46)
bfd82eb
@hendoncr
Add additional permissions to the ClusterRole (aws#52)
6cfd1c1
@runakash
Add the support for creating service with DNS namespace type (aws#48)
ba9b31c
@vanekjar
Fix controllers RBAC permissions (aws#54)
8f8df95
@vanekjar
Annotate imported EndpointSlices with multicluster label (aws#56)
4909140
@astaticvoid
Add API happy case unit tests (aws#58)
075bf73
@astaticvoid
Add janitor to clean up Cloud Map integration test resources (aws#57)
a132823
@astaticvoid
Fix multiple instance registration/deregistration (aws#60)
b49417a
@astaticvoid
Improve unit test coverage (aws#61)
15f8189
@runakash
Set AWS_REGION (aws#63)
4382eff
@runakash
Update controller docker version to v0.1.1 (aws#64)
7509127
@astaticvoid
Extract Cloud Map client cache (aws#67)
b6a739c
@astaticvoid
Replace ListInstances API calls with DiscoverInstances (aws#70)
3f8cbd8
@astaticvoid
Add integration test for service export (aws#69)
e7a9357
@vanekjar
Add architecture architecture to documentation (aws#72)
26134dc
bansal19 and others added 29 commits December 8, 2022 15:23
@bansal19
Check cluster ID during service export (aws#255)
d68c768 
Check cluster ID during service export
v0.3.1 release (aws#256)
887737e
@CurtisThe @jaywasd
Ipv6 (aws#257)
37a57ea 
* Support for IPv6 endpoints.

Co-authored-by: Jay Patel <jaywasd@amazon.com>
Co-authored-by: jaywasd <jnp2312@gmail.com>
@dependabot
Bump golang.org/x/time from 0.2.0 to 0.3.0 (aws#260)
bb6d804 
Bumps [golang.org/x/time](https://github.com/golang/time) from 0.2.0 to 0.3.0.
- [Release notes](https://github.com/golang/time/releases)
- [Commits](golang/time@v0.2.0...v0.3.0)

---
updated-dependencies:
- dependency-name: golang.org/x/time
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump github.com/aws/aws-sdk-go-v2 from 1.17.1 to 1.17.3 (aws#261)
feb22a2 
Bumps [github.com/aws/aws-sdk-go-v2](https://github.com/aws/aws-sdk-go-v2) from 1.17.1 to 1.17.3.
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/CHANGELOG.md)
- [Commits](aws/aws-sdk-go-v2@v1.17.1...v1.17.3)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump github.com/aws/aws-sdk-go-v2/service/servicediscovery (aws#259)
16ed152 
Bumps [github.com/aws/aws-sdk-go-v2/service/servicediscovery](https://github.com/aws/aws-sdk-go-v2) from 1.18.2 to 1.18.6.
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/CHANGELOG.md)
- [Commits](aws/aws-sdk-go-v2@config/v1.18.2...config/v1.18.6)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2/service/servicediscovery
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump github.com/aws/aws-sdk-go-v2/config from 1.18.3 to 1.18.7 (aws#258)
943eaff 
Bumps [github.com/aws/aws-sdk-go-v2/config](https://github.com/aws/aws-sdk-go-v2) from 1.18.3 to 1.18.7.
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/CHANGELOG.md)
- [Commits](aws/aws-sdk-go-v2@config/v1.18.3...config/v1.18.7)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2/config
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump github.com/emicklei/go-restful (aws#266)
9ddd40e 
Bumps [github.com/emicklei/go-restful](https://github.com/emicklei/go-restful) from 2.9.5+incompatible to 2.16.0+incompatible.
- [Release notes](https://github.com/emicklei/go-restful/releases)
- [Changelog](https://github.com/emicklei/go-restful/blob/v3/CHANGES.md)
- [Commits](emicklei/go-restful@v2.9.5...v2.16.0)

---
updated-dependencies:
- dependency-name: github.com/emicklei/go-restful
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump github.com/aws/aws-sdk-go-v2/service/servicediscovery (aws#265)
08d1903 
Bumps [github.com/aws/aws-sdk-go-v2/service/servicediscovery](https://github.com/aws/aws-sdk-go-v2) from 1.18.6 to 1.19.0.
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/CHANGELOG.md)
- [Commits](aws/aws-sdk-go-v2@config/v1.18.6...service/s3/v1.19.0)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2/service/servicediscovery
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump github.com/aws/aws-sdk-go-v2/config from 1.18.7 to 1.18.12 (aws#267
24583f7 
)

Bumps [github.com/aws/aws-sdk-go-v2/config](https://github.com/aws/aws-sdk-go-v2) from 1.18.7 to 1.18.12.
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/CHANGELOG.md)
- [Commits](aws/aws-sdk-go-v2@config/v1.18.7...config/v1.18.12)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2/config
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump golang.org/x/net from 0.0.0-20220722155237-a158d28d115b to 0.7.0 (…
451f134 
…aws#274)

Bumps [golang.org/x/net](https://github.com/golang/net) from 0.0.0-20220722155237-a158d28d115b to 0.7.0.
- [Release notes](https://github.com/golang/net/releases)
- [Commits](https://github.com/golang/net/commits/v0.7.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump golang.org/x/crypto from 0.0.0-20220214200702-86341886e292 to 0.…
3d121ee 
…1.0 (aws#275)

Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.0.0-20220214200702-86341886e292 to 0.1.0.
- [Release notes](https://github.com/golang/crypto/releases)
- [Commits](https://github.com/golang/crypto/commits/v0.1.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump github.com/aws/aws-sdk-go-v2 from 1.17.4 to 1.17.5 (aws#279)
9d6684a 
Bumps [github.com/aws/aws-sdk-go-v2](https://github.com/aws/aws-sdk-go-v2) from 1.17.4 to 1.17.5.
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/CHANGELOG.md)
- [Commits](aws/aws-sdk-go-v2@v1.17.4...v1.17.5)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump github.com/stretchr/testify from 1.8.1 to 1.8.2 (aws#277)
c1254a3 
Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.8.1 to 1.8.2.
- [Release notes](https://github.com/stretchr/testify/releases)
- [Commits](stretchr/testify@v1.8.1...v1.8.2)

---
updated-dependencies:
- dependency-name: github.com/stretchr/testify
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump github.com/aws/aws-sdk-go-v2/service/servicediscovery (aws#278)
35f92a7 
Bumps [github.com/aws/aws-sdk-go-v2/service/servicediscovery](https://github.com/aws/aws-sdk-go-v2) from 1.19.0 to 1.19.4.
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/CHANGELOG.md)
- [Commits](aws/aws-sdk-go-v2@service/s3/v1.19.0...service/efs/v1.19.4)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2/service/servicediscovery
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump github.com/aws/aws-sdk-go-v2/config from 1.18.12 to 1.18.15 (aws…
ceecd6f 
…#276)

Bumps [github.com/aws/aws-sdk-go-v2/config](https://github.com/aws/aws-sdk-go-v2) from 1.18.12 to 1.18.15.
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/CHANGELOG.md)
- [Commits](aws/aws-sdk-go-v2@config/v1.18.12...config/v1.18.15)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2/config
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump github.com/aws/aws-sdk-go-v2/config from 1.18.15 to 1.18.19 (aws…
c586797 
…#283)

Bumps [github.com/aws/aws-sdk-go-v2/config](https://github.com/aws/aws-sdk-go-v2) from 1.18.15 to 1.18.19.
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/CHANGELOG.md)
- [Commits](aws/aws-sdk-go-v2@config/v1.18.15...config/v1.18.19)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2/config
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump github.com/aws/aws-sdk-go-v2/service/servicediscovery (aws#282)
6bef326 
Bumps [github.com/aws/aws-sdk-go-v2/service/servicediscovery](https://github.com/aws/aws-sdk-go-v2) from 1.19.4 to 1.21.0.
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/CHANGELOG.md)
- [Commits](aws/aws-sdk-go-v2@service/efs/v1.19.4...service/s3/v1.21.0)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2/service/servicediscovery
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump github.com/go-logr/logr from 1.2.3 to 1.2.4 (aws#281)
c55daf6 
Bumps [github.com/go-logr/logr](https://github.com/go-logr/logr) from 1.2.3 to 1.2.4.
- [Release notes](https://github.com/go-logr/logr/releases)
- [Changelog](https://github.com/go-logr/logr/blob/master/CHANGELOG.md)
- [Commits](go-logr/logr@v1.2.3...v1.2.4)

---
updated-dependencies:
- dependency-name: github.com/go-logr/logr
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Update README.md (aws#314)
a66f87a 
* Update README.md

* Update README.md

* Update step by step guide link
@dependabot
Bump github.com/stretchr/testify from 1.8.2 to 1.8.4 (aws#290)
1235302 
Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.8.2 to 1.8.4.
- [Release notes](https://github.com/stretchr/testify/releases)
- [Commits](stretchr/testify@v1.8.2...v1.8.4)

---
updated-dependencies:
- dependency-name: github.com/stretchr/testify
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump github.com/aws/aws-sdk-go-v2 from 1.17.7 to 1.18.1 (aws#293)
632d136 
Bumps [github.com/aws/aws-sdk-go-v2](https://github.com/aws/aws-sdk-go-v2) from 1.17.7 to 1.18.1.
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/CHANGELOG.md)
- [Commits](aws/aws-sdk-go-v2@v1.17.7...v1.18.1)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Update github actions (aws#322)
a2a6b37
@dependabot
Bump golang.org/x/crypto from 0.1.0 to 0.17.0 (aws#320)
8614114 
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.1.0 to 0.17.0.
- [Commits](golang/crypto@v0.1.0...v0.17.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump google.golang.org/protobuf from 1.28.0 to 1.33.0 (aws#319)
7c038ef 
Bumps google.golang.org/protobuf from 1.28.0 to 1.33.0.

---
updated-dependencies:
- dependency-name: google.golang.org/protobuf
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Update go version (aws#323)
25cd6c1 
* Update go version

* Update go version
@dependabot
Bump github.com/aws/aws-sdk-go-v2/config from 1.18.19 to 1.20.0 (aws#307
6a4c981 
)

Bumps [github.com/aws/aws-sdk-go-v2/config](https://github.com/aws/aws-sdk-go-v2) from 1.18.19 to 1.20.0.
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/v1.20.0/CHANGELOG.md)
- [Commits](aws/aws-sdk-go-v2@config/v1.18.19...v1.20.0)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2/config
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Akash Rungta <runakash@amazon.com>
@jungrae-prestolabs
Add sync code when reconcille endpoint
73f6c2a
@jungrae-prestolabs
fx
f2f80ca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.