V4a async payload signing #6475
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagnir
force-pushed
the
dongie/sra-chunk-encoding-pt2
branch
5 times, most recently
from
966149f to
ef5d53f
Compare
dagnir
changed the base branch from
dongie/sra-chunk-encoding-pt1
to
feature/master/sra-async-chunked-encoding
dagnir
force-pushed
the
dongie/sra-chunk-encoding-pt2
branch
2 times, most recently
from
d4f0f87 to
5ac3968
Compare
zoewangg
reviewed
Oct 17, 2025
core/crt-core/src/main/java/software/amazon/awssdk/crtcore/CrtRequestBodyAdapter.java
Show resolved
Hide resolved
|
|
||
| @ParameterizedTest(name = "{index} {3}") | ||
| @MethodSource("streamingInputChecksumCalculationParams") | ||
| public void asyncStreamingInput_checksumCalculation(RequestChecksumCalculation requestChecksumCalculation, |
There was a problem hiding this comment.
Can we add an integ test as well?
| SdkHttpRequest.Builder request, Publisher<ByteBuffer> payload, String checksum) { | ||
|
|
||
| return SignerUtils.moveContentLength(request, payload) | ||
| .thenApply(p -> { |
There was a problem hiding this comment.
Question: is there any difference between sigv4a and sigv4 for this logic here?
There was a problem hiding this comment.
Nope, we can consolidate this.
There was a problem hiding this comment.
Actually nm, they're slightly different that it's a bit annoying to consolidate the two. The normal V4a version doesn't have a checksum parameter
...ava/software/amazon/awssdk/http/auth/aws/crt/internal/signer/AwsChunkedV4aPayloadSigner.java
Show resolved
Hide resolved
alextwoods
reviewed
Oct 20, 2025
...ava/software/amazon/awssdk/http/auth/aws/crt/internal/signer/AwsChunkedV4aPayloadSigner.java
Show resolved
Hide resolved
...ava/software/amazon/awssdk/http/auth/aws/crt/internal/signer/AwsChunkedV4aPayloadSigner.java
Outdated
Show resolved
Hide resolved
...ava/software/amazon/awssdk/http/auth/aws/crt/internal/signer/DefaultAwsCrtV4aHttpSigner.java
Outdated
Show resolved
Hide resolved
dagnir
changed the base branch from
feature/master/sra-async-chunked-encoding
to
master
dagnir
force-pushed
the
dongie/sra-chunk-encoding-pt2
branch
from
5ac3968 to
802f635
Compare
dagnir
force-pushed
the
dongie/sra-chunk-encoding-pt2
branch
from
a5b7bd0 to
dbb0e6a
Compare
|
dagnir
added
the
force-s3-regression-tests
dagnir
force-pushed
the
dongie/sra-chunk-encoding-pt2
branch
from
6fe5c9e to
f5876e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR adds support for async payload signing in the V4a signer. Note an important difference to the V4 implementation: This supports the fallback to signing the payload when the request is sent over
http. This is because calling thesignAsync()method previously always threwUnsupportedOperationException, so there is no risk of performance regression for existing users.Modifications
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License