Remove AmazonWebServiceResponse as base class for transfer utility repsonse objects. #4087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GarrettBeatty
force-pushed
the
GarrettBeatty/stacked/12
branch
from
c37c4da to
5aab0cd
Compare
This was referenced Oct 29, 2025
GarrettBeatty
commented
Oct 29, 2025
| { | ||
| sourceResponse.HttpStatusCode = HttpStatusCode.OK; | ||
| sourceResponse.ContentLength = 2048; | ||
| sourceResponse.ContentLength = 1024; |
Contributor
Author
There was a problem hiding this comment.
to match the value of 1024 we are populating in the headers too
GarrettBeatty
force-pushed
the
GarrettBeatty/stacked/12
branch
from
5aab0cd to
f37afba
Compare
philasmar
approved these changes
Nov 5, 2025
…psonse objects. stack-info: PR: #4087, branch: GarrettBeatty/stacked/12
GarrettBeatty
force-pushed
the
GarrettBeatty/stacked/12
branch
from
f37afba to
bedfd9d
Compare
10 tasks
dscpinheiro
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove AmazonWebServiceResponse as base class for transfer utility response objects. These shouldnt extend this class since its not the raw response from amazon web service.
Ran response mapper and transfer utility tests locally.
Dry run - c4907d4e-948c-49c2-9b57-57f93dbde562 - in progress