Tristin driver tutorial #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bquan0
requested changes
Oct 18, 2024
bquan0
requested changes
Oct 18, 2024
bquan0
requested changes
Oct 20, 2024
There was a problem hiding this comment.
The functionality looks good to me, just a few things in main.cpp that need to be fixed. Good job with fixing the I2C reads!
Also, for future reference, please resolve conversations after fixing them instead of reacting with 👍 . It makes reviewing the PR easier for me.
bquan0
requested changes
Oct 27, 2024
src/main.cpp
Outdated
| void setup() { | ||
| // TODO: initialize i2c and mcp23017 object | ||
| Wire.begin(); | ||
| uint8_t directions[8] = {1, 1, 1, 1, 1, 1, 1, 0}; |
There was a problem hiding this comment.
Good catch on the array not being 8 numbers long, but you still haven't addressed the problem I mentioned last time. According to the data sheet, 1 = input and 0 = output. If you wanted to turn on an LED with pin 0, would that require an input to the IO expander or an output from the IO expander?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the mc23017.cpp and main.cpp according to the driver tutorial for Bowen Quan