-
Couldn't load subscription status.
- Fork 112
legacy dependencies #148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
legacy dependencies #148
Conversation
|
Cool. I didn't even realise pip had an option to do this! |
I don't think that would do anything at present, since the workflow doesn't actually run pytest, or even install the package. It also appears that the CI action has not run for 2 years at this point - probably that maintenance should happen in a separate PR. |
|
Fair enough. I managed to get the tests running on my fork, but never really dug into what they were actually doing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still relevant? This looks good to me
Fixes #144
This PR is similar to #145, but implements the alternative strategy described in #144 of making deprecated dependencies optional on python 3.13.
This isn't necessarily meant to supersede #145, just to provide an alternative implementation that's ready to go in case @sampsyo wants to go this route instead.
Summary of changes:
audioop-ltsas a hard requirement onpython >= 3.13. This is necessary for thelin2linfunction used in all rawread paths.legacymode installation which includes dependencies forstandard-aifcandstandard-sunauifpython >= 3.13. Can be invoked bypython -m pip install audioread[legacy].