Skip to content

Conversation

@amogus07
Copy link
Contributor

@amogus07 amogus07 commented Oct 24, 2025

Description

I added type hints and refactored the modules to fix import cycles

To Do

  • Documentation
  • Changelog
  • Tests

@amogus07 amogus07 requested review from a team and semohr as code owners October 24, 2025 00:51
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @amogus07, your pull request is larger than the review limit of 150000 diff characters

@github-actions
Copy link

Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry.

@semohr
Copy link
Contributor

semohr commented Oct 24, 2025

Hey, thanks a lot for the contribution, really appreciate the effort you’ve put into this!

This PR is quite large, which makes it a bit difficult to review thoroughly. Would you mind breaking it down into smaller, more focused commits or separate PRs? For instance, you could move file relocations or refactors into their own commits to make the changes easier to follow. You can take a look at the PR linked below for an example of how to structure these kinds of refactors.

It also looks like this PR touches on multiple areas of the codebase. To keep things maintainable and easier to review, it’s best if each PR focuses on a single concern or goal, rather than combining several changes at once.

As a side note, have you had a chance to look at #6119? It seems to address some of the same issues you’re working on here, it might be worth aligning with that effort to avoid overlap.

Thanks again for your work on this! We really appreciate your recent efforts!

@amogus07 amogus07 changed the title refactor util and ui + add lots of type hints add lots of type hints Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants