cmake: add ONLY_CAPNP target_capnp_sources option #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make `target_capnp_sources` function take `ONLY_CAPNP` option to only add cap'n proto-generated files to the target library and not add libmultiprocess-generated ones. This is needed in bitcoin/bitcoin#10102 to support building with ENABLE_IPC=ON and ENABLE_WALLET=OFF because libmultiprocess-generated wallet files `wallet.capnp.proxy*.c++` can't be built without causing link errors, while the `wallet.capnp.c++` file is still necessary to build because it is referenced by `init.capnp` and `node.capnp` there.
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
This was referenced Oct 22, 2025
hebasto
reviewed
Nov 4, 2025
Comment on lines
-114
to
+119
| add_custom_target("${target}_headers" DEPENDS ${generated_headers}) | ||
| if(NOT TARGET "${target}_headers") | ||
| add_custom_target("${target}_headers" DEPENDS ${generated_headers}) | ||
| endif() |
There was a problem hiding this comment.
These changes are reasonable on their own. Maybe split them into a separate commit?
nit: I don’t think quoting is needed here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
target_capnp_sourcesfunction takeONLY_CAPNPoption to only add cap'n proto-generated files to the target library and not add libmultiprocess-generated ones.This is needed in bitcoin/bitcoin#10102 to support building with ENABLE_IPC=ON and ENABLE_WALLET=OFF because libmultiprocess-generated wallet files
wallet.capnp.proxy*.c++can't be built without causing link errors, while thewallet.capnp.c++file is still necessary to build because it is referenced byinit.capnpandnode.capnpthere.