Tutorial exercise 1 uses example that is more conducive to learning #840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jesse Carnaxide <jcarnaxide@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #840 +/- ##
=======================================
Coverage 92.39% 92.39%
=======================================
Files 99 99
Lines 11840 11840
Branches 425 425
=======================================
Hits 10940 10940
Misses 900 900
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@godlygeek I believe this PR is suitable for review. Are there any other steps I should follow to indicate this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#839
Updated the values as well as layout of code in exercise 1 of the hands-on tutorials. Now the allocations appear as 3 separate branches in the flamegraphs, each of different relative size. This allows for a better example to illustrate how flamegraphs are meant to be read (specifically showing the x-axis represents relative memory allocation amount.)
I ran this new example locally, with/without solution implemented. New flamegraphs look good. Tests fail/pass the way expected. I also included an updated image of the generated flamegraph with the initial codeset (as intended to be viewed while following the tutorial).