-
Notifications
You must be signed in to change notification settings - Fork 11
[fix] Stagehand Agent param is instructions instead of systemPrompt #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] Stagehand Agent param is instructions instead of systemPrompt #24
Conversation
… a systemPrompt instead, I noticed this while running npx create-browser-app and seeing the error appear
Kylejeong2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @bennycortese, thanks for making this PR!
Could you pnpm changeset and version a patch here and recommit?
I can merge/release to NPM later on. Thanks!
Hey @Kylejeong2, thank you for reviewing this PR! I tried to make a new patch file, let me know if I should make it as a minor patch instead or do anything differently Thank you! |
|
Hey @bennycortese, did you run both pnpm changeset & pnpm run version? The changes aren't showing up in the changelog.md file. |
Kylejeong2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you run the pnpm version so we can get the change into the changelog.md? thanks so much!
…version should be 2.5.1 but changelog is defaulting to this
Done! Sorry for the delay, busy week - also sorry for the spam of commits, was making sure the changelog seems right + versioning is updated correctly - thank you! |
Kylejeong2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, lets ship it!
Stagehand agent no longer directly takes in instructions. It takes in a systemPrompt instead, I noticed this while running npx create-browser-app and seeing the error appear