[TKT-15] getSnapshot fixes for Old Agent + new Agent

[shivammittal274]

No description provided.

[greptile-apps]

Greptile Overview

Greptile Summary

This PR adds support for a new snapshot format from BrowserOS that uses an items-based structure instead of the sections-based format. The implementation uses a feature flag (NEW_SNAPSHOT_FORMAT) to switch between old and new formats at runtime.

Key Changes:

• Added type definitions for NewSnapshot with items array containing {type, text, url, level} objects
• Modified BrowserOSAdapter.getSnapshot() to conditionally call different Chrome API signatures based on feature flag
• Added format detection and parsing helpers in BrowserPage to handle both formats transparently
• Refactored ChatAgent and Extract tool to use unified snapshot methods that abstract format differences

Issues Found:

• Critical type mismatch in BrowserOSAdapter.ts:434-435 where Promise and callback are typed as Snapshot but should be SnapshotResult
• Logic error in BrowserPage.ts:945 where getTextWithLinksString() requests 'links' type instead of 'text' type
• Redundant feature flag checks in multiple layers
• Minor code style inconsistencies

Confidence Score: 2/5

• This PR has critical type errors that will cause TypeScript compilation issues and potential runtime failures
• Score of 2 reflects critical type mismatches in BrowserOSAdapter (Promise vs Promise) that will cause TypeScript errors, plus a logic error in snapshot type selection. While the overall architecture is sound, these issues must be fixed before merging
• Pay close attention to src/lib/browser/BrowserOSAdapter.ts (type mismatches on lines 434-435) and src/lib/browser/BrowserPage.ts (incorrect snapshot type on line 945)

Important Files Changed

File Analysis

Filename	Score	Overview
src/lib/browser/BrowserOSAdapter.ts	2/5	Added snapshot format detection and union type support, but has critical type mismatches in Promise and callback declarations
src/lib/browser/BrowserPage.ts	3/5	Added format detection helpers and new getTextWithLinksString method, but has logic issue with snapshot type selection and minor inconsistencies
src/lib/tools/Extract.ts	4/5	Refactored to use helper functions and support both snapshot formats with redundant feature flag checks but otherwise solid

Sequence Diagram

sequenceDiagram
    participant Client as ChatAgent/Extract Tool
    participant BPage as BrowserPage
    participant Adapter as BrowserOSAdapter
    participant FF as FeatureFlags
    participant Chrome as chrome.browserOS

    Client->>BPage: getTextSnapshotString(options)
    BPage->>Adapter: getSnapshot(tabId, 'text', options)
    Adapter->>FF: isEnabled('NEW_SNAPSHOT_FORMAT')
    FF-->>Adapter: true/false
    
    alt New Format Enabled
        Adapter->>Chrome: getSnapshot(tabId, [options], callback)
        Chrome-->>Adapter: NewSnapshot (items: [{type, text, url}])
    else Old Format
        Adapter->>Chrome: getSnapshot(tabId, 'text', [options], callback)
        Chrome-->>Adapter: Snapshot (sections: [...])
    end
    
    Adapter-->>BPage: SnapshotResult (union type)
    BPage->>BPage: _isNewSnapshot(snapshot)
    
    alt New Format
        BPage->>BPage: _formatNewSnapshot(snapshot, includeLinks)
        Note over BPage: Format items as markdown<br/># headings, [text](url)
    else Old Format
        BPage->>BPage: _formatOldSnapshot(snapshot, includeLinks)
        Note over BPage: Extract from sections.textResult
    end
    
    BPage-->>Client: Formatted string content

Loading

_{6 files reviewed, 3 comments}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

syntax: Return type mismatch: Promise is typed as Promise<Snapshot> but method signature returns Promise<SnapshotResult>

Suggested change

	return new Promise<Snapshot>((resolve, reject) => {
	return new Promise<SnapshotResult>((resolve, reject) => {

Prompt To Fix With AI

This is a comment left during a code review.
Path: src/lib/browser/BrowserOSAdapter.ts
Line: 434:434

Comment:
**syntax:** Return type mismatch: Promise is typed as `Promise<Snapshot>` but method signature returns `Promise<SnapshotResult>`

```suggestion
      return new Promise<SnapshotResult>((resolve, reject) => {
```

How can I resolve this? If you propose a fix, please make it concise.

[greptile-apps]

syntax: Callback parameter type should be SnapshotResult not Snapshot to match union type

Suggested change

	const callback = (snapshot: Snapshot) => {
	const callback = (snapshot: SnapshotResult) => {

Prompt To Fix With AI

This is a comment left during a code review.
Path: src/lib/browser/BrowserOSAdapter.ts
Line: 435:435

Comment:
**syntax:** Callback parameter type should be `SnapshotResult` not `Snapshot` to match union type

```suggestion
        const callback = (snapshot: SnapshotResult) => {
```

How can I resolve this? If you propose a fix, please make it concise.

[greptile-apps]

logic: Should use 'text' type instead of 'links' for text-with-links mode - links are fetched with text type in new format

Prompt To Fix With AI

This is a comment left during a code review.
Path: src/lib/browser/BrowserPage.ts
Line: 945:945

Comment:
**logic:** Should use `'text'` type instead of `'links'` for text-with-links mode - links are fetched with text type in new format

How can I resolve this? If you propose a fix, please make it concise.