-
Notifications
You must be signed in to change notification settings - Fork 27
[DPE-8781] Disable CA for replication user #1274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 16/edge
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 16/edge #1274 +/- ##
========================================
Coverage 70.73% 70.73%
========================================
Files 16 16
Lines 4043 4043
Branches 629 629
========================================
Hits 2860 2860
Misses 991 991
Partials 192 192 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6cc3495 to
a8e7d60
Compare
a8e7d60 to
04c6609
Compare
7da79bd to
9be6425
Compare
9be6425 to
c40bccf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switchover fixes were merged so we can test edge or stable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partial copy of the async test with spaces.
| model_2 = Juju(model=model_name) | ||
| model_2.cli("reload-spaces") | ||
| model_2.cli("add-space", "client", "10.0.0.1/24") | ||
| model_2.cli("add-space", "peers", "10.10.10.1/24") | ||
| model_2.cli("add-space", "isolated", "10.20.20.1/24") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add spaces for the second model.
| model_1.offer(f"{first_model}.self-signed-certificates", endpoint="send-ca-cert") | ||
| model_2.consume(f"{first_model}.self-signed-certificates", "send-ca-offer") | ||
| model_2.integrate(DB_APP_2, "send-ca-offer") | ||
| model_2.offer(f"{second_model}.self-signed-certificates", endpoint="send-ca-cert") | ||
| model_1.consume(f"{second_model}.self-signed-certificates", "send-ca-offer") | ||
| model_1.integrate(DB_APP_1, "send-ca-offer") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we transfer CAs here or test without?
| {%- if enable_tls %} | ||
| sslrootcert: {{ conf_path }}/ca.pem | ||
| {%- endif %} | ||
| sslrootcert: {{ conf_path }}/nonexistent_cert.pem |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Breaks base backup while syncing the standby leader from the primary cluster.
I think the root issue is that in the snap service $HOME is set to the snap revision directory and PG utilities cannot access .postgresql directory there.
pg_basebackupfails to run when replicating from a primary cluster during async replication with TLS.Checklist