Skip to content

chore(clerk-js,types): Remove deprecated UserSettings.saml #7063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: vincent-and-the-doctor
Choose a base branch
from
Open

chore(clerk-js,types): Remove deprecated UserSettings.saml #7063

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/happy-apes-care.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@clerk/clerk-js': patch
'@clerk/types': patch
---

Remove deprecated `saml` property from `UserSettings` in favor of `enterpriseSSO`
6 changes: 0 additions & 6 deletions packages/clerk-js/src/core/resources/UserSettings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import type {
PasskeySettingsData,
PasswordSettingsData,
PhoneCodeChannel,
SamlSettings,
SignInData,
SignUpData,
UsernameSettingsData,
Expand Down Expand Up @@ -112,9 +111,6 @@ export class UserSettings extends BaseResource implements UserSettingsResource {
show_sign_in_button: false,
};
passwordSettings: PasswordSettingsData = {} as PasswordSettingsData;
saml: SamlSettings = {
enabled: false,
};
signIn: SignInData = {
second_factor: {
required: false,
Expand Down Expand Up @@ -229,7 +225,6 @@ export class UserSettings extends BaseResource implements UserSettingsResource {
: Math.min(data.password_settings?.max_length ?? defaultMaxPasswordLength, defaultMaxPasswordLength),
}
: this.passwordSettings;
this.saml = this.withDefault(data.saml, this.saml);
this.signIn = this.withDefault(data.sign_in, this.signIn);
this.signUp = this.withDefault(data.sign_up, this.signUp);
this.social = this.withDefault(data.social, this.social);
Expand All @@ -256,7 +251,6 @@ export class UserSettings extends BaseResource implements UserSettingsResource {
attributes: this.attributes,
passkey_settings: this.passkeySettings,
password_settings: this.passwordSettings,
saml: this.saml,
sign_in: this.signIn,
sign_up: this.signUp,
social: this.social,
Expand Down
13 changes: 0 additions & 13 deletions packages/types/src/userSettings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,11 +86,6 @@ export type PasskeySettingsData = {
export type OAuthProviders = {
[provider in OAuthStrategy]: OAuthProviderSettings;
};

export type SamlSettings = {
enabled: boolean;
};

export type EnterpriseSSOSettings = {
enabled: boolean;
};
Expand All @@ -115,10 +110,6 @@ export interface UserSettingsJSON extends ClerkResourceJSON {
actions: Actions;
social: OAuthProviders;

/**
* @deprecated Use `enterprise_sso` instead.
*/
saml: SamlSettings;
enterprise_sso: EnterpriseSSOSettings;

sign_in: SignInData;
Expand All @@ -132,10 +123,6 @@ export interface UserSettingsResource extends ClerkResource {
id?: undefined;
social: OAuthProviders;

/**
* @deprecated Use `enterprise_sso` instead.
*/
saml: SamlSettings;
enterpriseSSO: EnterpriseSSOSettings;

attributes: Attributes;
Expand Down