-
Couldn't load subscription status.
- Fork 643
spacetime init rewrite
#3366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
spacetime init rewrite
#3366
Conversation
c022d34 to
ea0f0f7
Compare
ea0f0f7 to
e536cc3
Compare
10f14ee to
cc118cc
Compare
Signed-off-by: Tyler Cloutier <cloutiertyler@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some UX questions/nits about github templates, I'm still reviewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More review
…etimeDB into drogus/spacetime-init
…les with fallbacks for connecting to SpacetimeDB
…side of the crate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some docs feedback for now
|
|
||
| ```bash | ||
| spacetime init --lang=rust server-rust | ||
| spacetime init --lang rust server-rust |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case I'm being prompted for a project path, I think most users would be smart enough to just press enter to do the default thing but maybe it would be good to just include the --project-path option here so that users don't get prompted?
| spacetime init --lang rust server-rust | ||
| ``` | ||
|
|
||
| This command creates a new folder named `server-rust` alongside your Unity project `client-unity` directory and sets up the SpacetimeDB server project with Rust as the programming language. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The instructions now create a directory structure which looks like this:
boppy@geralt MINGW64 ~/clockwork/tmp
$ ls
server-rust/
boppy@geralt MINGW64 ~/clockwork/tmp
$ ls server-rust/
spacetimedb/
boppy@geralt MINGW64 ~/clockwork/tmp
$ ls server-rust/spacetimedb/
Cargo.toml src/
I think we need to update the tutorials to use the new flow otherwise some of these steps will be out of date and won't work. For Unity specifically we might want people to run the spacetime init ... command first so that they can then open Unity in the project directory so that Unity can populate the required files. Although I'm not sure if you can create a new Unity project in a directory which already contains files.
I'm happy to help with this if needed 🙂
…s/SpacetimeDB into drogus/spacetime-init
This is a draft of the new functionality for
spacetime init. In order to run it with built-in templates you have to set the path to the config file:In the future it will fetch the list from GH.
A few notes:
spacetime initdoes not work at the momentspacetimedbdirectory for the server filesmissing --foo, we will automatically launch interactive mode, which is harder to debug. That's why I think I'd prefer to implement--non-interactiveargument--langor--project-pathexplicitly, I guess we could run the legacy workflow, but not sure if it's worth it, as the command was marked as unstable anyway