Skip to content

Allow passing a roleArn and externalId when using ENV #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: alpha
Choose a base branch
from
Open

Allow passing a roleArn and externalId when using ENV #163

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd1ebb8
Allow passing a roleArn and externalId when using ENV
rbclark Sep 25, 2023
a8383a6
Merge branch 'alpha' into add-assume-role-to-env
rbclark Nov 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/services/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,6 +435,16 @@ export default class Provider extends CloudGraph.Client {
}
if (usingEnvCreds) {
this.logger.success('Using credentials set by ENV variables')
if(role) {
this.logger.success(`roleARN: ${chalk.underline.green(
obfuscateSensitiveString(role)
)}`)
}
if(externalId) {
this.logger.success(`externalId: ${chalk.underline.green(
obfuscateSensitiveString(externalId)
)}`)
}
} else {
this.logger.success('Found and using the following AWS credentials')
this.logger.success(
Expand Down Expand Up @@ -696,7 +706,7 @@ export default class Provider extends CloudGraph.Client {
// If the user has passed aws creds as env variables, dont use profile list
if (usingEnvCreds) {
let {rawData: results, regions: activeRegions} = await this.getRawData(
{ profile: 'default', roleArn: undefined, externalId: undefined },
{ profile: 'default', roleArn: process.env.AWS_ROLE_ARN, externalId: process.env.AWS_ROLE_EXTERNAL_ID },
opts
)

Expand Down