insights: skip contention test under duress #156317
Open
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves: cockroachdb#155838 Resolves: cockroachdb#155962 Epic: None Release note: None
|
This change is |
dhartunian
added
backport-25.3.x
alyshanjahani-crl
approved these changes
Oct 28, 2025
|
bors r=alyshanjahani-crl |
craig bot
pushed a commit
that referenced
this pull request
Oct 28, 2025
156306: changefeedccl: enable a couple of tests with test tenant r=yuzefovich a=yuzefovich Fixes: #98816 Informs: #142799 Release note: None 156317: insights: skip contention test under duress r=alyshanjahani-crl a=dhartunian Resolves: #155838 Resolves: #155962 Epic: None Release note: None 156387: catalog/lease: address deadlock with locked lease timestamps r=fqazi a=fqazi Previously, when locked lease timestamps were used, we held the descriptor state while acquiring close timestamp handles. This could lead to a deadlock, since in other code paths we acquire the close timestamp handle first. To address this, this patch avoids holding the descriptor state lock longer than necessary. Fixes: #156177 Release note: None 156388: cliccl: fix FIPS-readiness check r=rail a=rickystewart The logic here is flipped. Release note: none Epic: DEVINF-1477 Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com> Co-authored-by: David Hartunian <davidh@cockroachlabs.com> Co-authored-by: Faizan Qazi <faizan@cockroachlabs.com> Co-authored-by: Ricky Stewart <ricky@cockroachlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #155838
Resolves: #155962
Epic: None
Release note: None