Alter RBR locality is blocked by sql_safe_updates #20856
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
Files changed:
|
rmloveland
force-pushed
the
20251028-DOC-14722-block-rbr-with-sql-safe-updates
branch
from
f32f714 to
ef00b8f
Compare
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Author
|
@rafiss based on the labels on your PR cockroachdb/cockroach#151423 it looks like this change is in every supported version v24.1+, is that correct? |
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
rafiss
approved these changes
Nov 4, 2025
Contributor
rafiss
left a comment
rafiss
left a comment
There was a problem hiding this comment.
lgtm! I'm pretty sure you only made these changes in 25.4 initially for ease of review, but just in case this wasn't known already: we backported this behavior to v24.1.24, 24.3.20, v25.2.6, and v25.3.2 also. (links can be seen on the original issue: cockroachdb/cockroach#150945)
Contributor
Author
|
Thanks Rafi! Yes, def planning to backport to the docs for the various
supported versions. Sorry, I meant to say that but must have forgotten
to.
Been experimenting for a bit with PRing changes in v25.4 (or whatever is
latest) and then mechanically backporting to prev supported versions
with a script, mostly to ease reviewer burden of scanning through
multiple duplicate edits (Docs team may move to branch-based versioning
at some point but it's not in near term plans AIUI)
Rafi Shamim ***@***.***> writes:
… @rafiss approved this pull request.
lgtm! I'm pretty sure you only made these changes in 25.4 initially
for ease of review, but just in case this wasn't known already: we
backported this behavior to v24.1.24, 24.3.20, v25.2.6, and v25.3.2
also. (links can be seen on the original issue:
cockroachdb/cockroach#150945)
|
rmloveland
deleted the
20251028-DOC-14722-block-rbr-with-sql-safe-updates
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DOC-14722