Skip to content

fix: add internalInfra #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: add internalInfra #636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a48ec4d
fix: add internalInfra
mikhail-klimko Nov 3, 2025
b200820
fix: add internalInfra
mikhail-klimko Nov 3, 2025
14eb113
fix: add internalInfra
mikhail-klimko Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions charts/cf-runtime/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v2
description: A Helm chart for Codefresh Runner
name: cf-runtime
version: 8.3.15
version: 8.3.16
keywords:
- codefresh
- runner
Expand All @@ -16,13 +16,9 @@ annotations:
# 💡 Do not forget to update this annotation:
artifacthub.io/containsSecurityUpdates: "true"
# Supported kinds: `added`, `changed`, `deprecated`, `removed`, `fixed`, `security`:
artifacthub.io/changes: |
- kind: changed
description: "Update \"engine\" to 1.180.6"
- kind: fixed
description: "Fix an issue that prevented the Docker metrics collector from shutting down gracefully"
- kind: security
description: "Security fixes in cf-debugger, cf-git-cloner, cli, dind, engine, fs-ops and kubectl"
artifacthub.io/changes: | #yaml
- kind: added
description: "Add runtimeScheduler.internalInfra field to runtime spec"
dependencies:
- name: cf-common
repository: oci://quay.io/codefresh/charts
Expand Down
2 changes: 1 addition & 1 deletion charts/cf-runtime/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
## Codefresh Runner

![Version: 8.3.15](https://img.shields.io/badge/Version-8.3.15-informational?style=flat-square)
![Version: 8.3.16](https://img.shields.io/badge/Version-8.3.16-informational?style=flat-square)

Helm chart for deploying [Codefresh Runner](https://codefresh.io/docs/docs/installation/codefresh-runner/) to Kubernetes.

Expand Down
8 changes: 8 additions & 0 deletions charts/cf-runtime/templates/runtime/runtime-env-spec-tmpl.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,11 @@ metadata:
agent: {{ .Values.runtime.agent }}
runtimeScheduler:
type: KubernetesPod
{{- if .Values.runtime.agent }}
Copy link
Contributor

@masontikhonov masontikhonov Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if these two values should depend on each other from onprem perspective.

internalInfra: false
{{- else }}
internalInfra: true
{{- end }}
{{- if $engineContext.image }}
image: {{ include (printf "%s.image.name" $cfCommonTplSemver ) (dict "image" $engineContext.image "context" .) | squote }}
{{- end }}
Expand Down Expand Up @@ -324,4 +329,7 @@ appProxy:
{{- if not .Values.runtime.agent }}
systemHybrid: true
{{- end }}
{{- if not .Values.runtime.agent }}
environmentCertPath: /etc/ssl/cf/
{{- end }}
{{- end }}
5 changes: 3 additions & 2 deletions charts/cf-runtime/tests/private-registry/private_registry_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# yaml-language-server: $schema=https://raw.githubusercontent.com/quintush/helm-unittest/master/schema/helm-testsuite.json
# yaml-language-server: $schema=https://raw.githubusercontent.com/helm-unittest/helm-unittest/main/schema/helm-testsuite.json
suite: private_registry test
values:
- ../values.yaml
Expand All @@ -18,12 +18,13 @@ tests:
asserts:
- equal:
path: data["my-context-codefresh.yaml"]
value: |
value: | #yaml
metadata:
name: my-context/codefresh
agent: true
runtimeScheduler:
type: KubernetesPod
internalInfra: false
image: 'somedomain.io/codefresh/engine:tagoverride'
imagePullPolicy: IfNotPresent
command:
Expand Down
6 changes: 4 additions & 2 deletions charts/cf-runtime/tests/runtime/runtime_onprem_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,13 @@ tests:
asserts:
- equal:
path: data["my-runtime.yaml"]
value: |
value: | #yaml
metadata:
name: system/my-runtime
agent: false
runtimeScheduler:
type: KubernetesPod
internalInfra: true
image: 'quay.io/codefresh/engine:tagoverride'
imagePullPolicy: IfNotPresent
command:
Expand Down Expand Up @@ -248,12 +249,13 @@ tests:
asserts:
- equal:
path: data["default-override.yaml"]
value: |
value: | #yaml
metadata:
name: system/default-override
agent: false
runtimeScheduler:
type: KubernetesPod
internalInfra: true
image: 'quay.io/codefresh/engine:tagoverride'
imagePullPolicy: IfNotPresent
command:
Expand Down
5 changes: 3 additions & 2 deletions charts/cf-runtime/tests/runtime/runtime_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# yaml-language-server: $schema=https://raw.githubusercontent.com/quintush/helm-unittest/master/schema/helm-testsuite.json
# yaml-language-server: $schema=https://raw.githubusercontent.com/helm-unittest/helm-unittest/main/schema/helm-testsuite.json
suite: runtime test
values:
- ../values.yaml
Expand Down Expand Up @@ -30,12 +30,13 @@ tests:
asserts:
- equal:
path: data["my-context-codefresh.yaml"]
value: |
value: | #yaml
metadata:
name: my-context/codefresh
agent: true
runtimeScheduler:
type: KubernetesPod
internalInfra: false
image: 'quay.io/codefresh/engine:tagoverride@sha256:123'
imagePullPolicy: Always
command:
Expand Down