Skip to content

Conversation

@burgerga
Copy link
Contributor

@burgerga burgerga commented Oct 26, 2025

✍️ Description

  • Updates unrar (non-free) sources to trixie and deb822
  • Include optional installation of par2cmdline-turbo

Updated PR:

  • switched order update to first check for par2cmdline-turbo update -> this leaves existing sabnzbd update code unchanged
  • Removed duplicate setup_uv
  • Removed duplicated msg_ calls around setup_uv

Update function is changed to allow updating par2cmdline-turbo independent from sabnzbd, for this the sabnzbd update code had to be moved in the else part of the if statement; the only change is the indentation.

🔗 Related PR / Issue

Link: #6059 (discussion)

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

- Don't delete after use
- Use trixie instead of bookworm
- deb822 style
@burgerga burgerga requested a review from a team as a code owner October 26, 2025 15:47
@github-actions github-actions bot added feature refactor update script A change that updates a script labels Oct 26, 2025
@CrazyWolf13
Copy link
Member

would be awesome, if you could take a look at the things, then sabnzbd is updated to our new toolset too ^^

@burgerga
Copy link
Contributor Author

Sure! Will take me a little longer though to see what everything is doing, because I didn't write that code, I just indented it :)

@burgerga burgerga force-pushed the feat_sabnzbd_par2cmdline branch from f36e4d5 to f5b5aef Compare October 26, 2025 18:34
@burgerga burgerga requested a review from CrazyWolf13 October 26, 2025 18:42
@burgerga
Copy link
Contributor Author

Updated the order in the update function so this PR no longer touches the existing sabnzbd update code :)

@burgerga
Copy link
Contributor Author

@CrazyWolf13 done! As discussed with @MickLesk on discord I used sabnzbd-org as name, bacause sabnzbd uses ~/.sabnzbd/ as conf directory

Added virtual environment setup and package installation for SABnzbd.
@MickLesk MickLesk removed the request for review from CrazyWolf13 October 28, 2025 17:09
@MickLesk MickLesk merged commit c84c448 into community-scripts:main Oct 28, 2025
2 checks passed
@burgerga burgerga deleted the feat_sabnzbd_par2cmdline branch October 28, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature refactor update script A change that updates a script

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants