[wip] Run C++ tests in Valgrind ci #405
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #405 +/- ##
=======================================
Coverage 81.77% 81.77%
=======================================
Files 20 20
Lines 845 845
Branches 87 87
=======================================
Hits 691 691
Misses 154 154 🚀 New features to boost your workflow:
|
Collaborator
Author
|
I am not sure what is going wrong with using Valgrind on Ubuntu arm runners in the ci (see https://github.com/compiler-research/xeus-cpp/actions/runs/19150317221/job/54738556792?pr=405 ) . This Valgrind error doesn't occur when I run same command locally (and how I managed to produce the Valgrind suppression file. I don't know how to interpret the suppression files, so unsure if there is anything in there that we don't want to suppress. |
Collaborator
|
Why is this PR needed in the first place ? P.S : Asking as someone who is clueless about Valgrind. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of changes, motivation and context for this PR.
Fixes # (issue)
Type of change
Please tick all options which are relevant.