Add command to transfer ownership #1609
Conversation
| $package->addMaintainer($maintainer); | ||
| } | ||
|
|
||
| $this->doctrine->getManager()->persist(AuditRecord::packageTransferred($package, null, $oldMaintainers, array_values($maintainers))); |
There was a problem hiding this comment.
What about packages that were already own by the new maintainers ? Should they actually be marked as transferred to the same maintainers ?
There was a problem hiding this comment.
Based on my understanding, this transfer command is only necessary when people no longer have access, and it's highly unlikely that current maintainers remain in place. Besides that, storing all old and new maintainers also tells us exactly what arguments the command was used with?
There was a problem hiding this comment.
When applying that to a whole vendor namespace, the existing packages might have different maintainers. Maybe one of them already has only the new maintainers.
There was a problem hiding this comment.
Yeah I think what we could do here is at least check that the old and new arent' an exact match and if they are skip transferring that package as that's a noop. I'll add that post merge.
|
Alright cool, works well :) https://packagist.org/audit-log?type%5B%5D=package_transferred |
Adds a
packagist:transfer-ownershipcommand to change maintainers for multiple packages at once.