Bugfix/sitecore zip issue #821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tack/migration-v2 into bugfix/sitecore-zip
…nd error handling. Standardize string quotes, enhance file format validation, and add console warnings for incomplete steps in Legacy CMS. Update configuration for local path.
…to bugfix/sitecore-zip-issue
…ependencies for better clarity in development environment
sauravraw
requested review from
sayalijoshi27 and
umeshmore45
and removed request for
a team and
umeshmore45
sayalijoshi27
requested changes
Oct 31, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR updates the migration system to handle nested Sitecore ZIP files and upgrades the @contentstack/json-rte-serializer package from v2 to v3.0.4 across multiple packages.
Key changes:
- Added support for detecting and extracting nested ZIP files in Sitecore migrations
- Enhanced locale extraction with better performance logging and directory filtering
- Fixed UID generation logic to handle restricted keywords and numeric prefixes
- Improved dropdown field handling by conditionally setting the
advancedflag - Added date/isodate field parsing support for Sitecore format dates
- Upgraded
@contentstack/json-rte-serializerdependency to v3.0.4
Reviewed Changes
Copilot reviewed 22 out of 30 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| upload-api/src/validators/sitecore/index.ts | Added nested ZIP file detection and validation logic |
| upload-api/src/helper/index.ts | Enhanced saveZip to extract and process nested Sitecore archives |
| upload-api/migration-sitecore/libs/extractLocales.js | Refactored to use local Set, added logging and performance tracking |
| upload-api/migration-sitecore/libs/convert.js | Added XML validation checks before parsing |
| upload-api/migration-sitecore/libs/contenttypes.js | Enhanced UID correction and dropdown field handling |
| ui/src/pages/Migration/index.tsx | Added unmount cleanup and improved error handling |
| ui/src/components/LegacyCms/Actions/LoadFileFormat.tsx | Simplified file format extraction logic |
| api/src/utils/entries-field-creator.utils.ts | Added Sitecore date format parsing support |
| api/src/utils/content-type-creator.utils.ts | Fixed dropdown advanced flag logic and UID cleaning |
Files not reviewed (3)
- upload-api/migration-contentful/package-lock.json: Language not supported
- upload-api/migration-sitecore/package-lock.json: Language not supported
- upload-api/migration-wordpress/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…thods; streamline ESLint configuration
…son and package-lock.json to latest versions for improved functionality and security
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.