Compiler fixes #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ltiplyVec4 had the wrong types
coreh#3 Apparently it doesn't matter that much: http://stackoverflow.com/q/501839/115589 Also removed an apparently stray double_t
…der file library (see https://github.com/nothings/stb if unclear) Simplified the rest of the Makefile
…oats or doubles at will
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thanks for this library. It is very convenient to have a simple library like this for my graphics hobbies.
Here are some changes I've made to my fork to eliminate some compiler warnings:
calloc()calls I've swapped thenitemsandsizeparametersmat4_multiplyVec3andmat4_multiplyVec4had the wrong parameters and return types.oto thealltarget in the Makefile to eliminate some unnecessary compiles