Skip to content

DOC-13347 fix unreadable inline example #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

DOC-13347 fix unreadable inline example #195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25d9d45
DOC-13347 fix unreadable inline example
osfameron Jul 1, 2025
c717239
DOC-13355 remove responsive table switch
osfameron Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/css/base.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,11 @@ code {
color: inherit;
}

Copy link

Copilot AI Jul 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a comment above these rules to explain that they override highlightjs colors for redoc inline examples, which can help future maintainers understand the purpose of this override.

Suggested change
/* Override Highlight.js colors for Redoc inline examples to ensure consistent styling */

Copilot uses AI. Check for mistakes.
#redoc .hljs-comment,
#redoc .hljs-meta {
color: inherit;
}

a code {
color: var(--color-link);
background-color: transparent;
Expand Down
4 changes: 3 additions & 1 deletion src/css/table.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ table.table-tutorial tr td:last-child {

/* Responsive css */

@media screen and (min-width: 768px) {
@media screen and (min-width: 1px /*768px*/) {
Comment on lines 155 to +156
Copy link

Copilot AI Jul 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The inline comment inside the media query breakpoint may be confusing. Consider removing the commented '/768px/' or moving it to a clear code comment above the rule for clarity.

Copilot uses AI. Check for mistakes.
table.tableblock {
display: table;
position: relative;
Expand Down Expand Up @@ -212,6 +212,7 @@ table.table-tutorial tr td:last-child {
}
}

/* This "responsive" table CSS is a bit odd, I'm not sure it is needed any more:
Copy link

Copilot AI Jul 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Commented-out code can accumulate and hinder maintainability. If this responsive block is no longer needed, consider removing it or adding a TODO with context and a link to the issue tracking its removal.

Copilot uses AI. Check for mistakes.
@media screen and (max-width: 767px), print {
table.tableblock td,
table.tableblock th {
Expand Down Expand Up @@ -242,3 +243,4 @@ table.table-tutorial tr td:last-child {
max-width: 120px;
}
}
*/