-
Notifications
You must be signed in to change notification settings - Fork 799
[exec.run.loop] Remove code font formatting for count and state #8307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@jwakely , having exposition-only data members and an exposition-only enumeration might be the better outcome here, but that leaves the atomic nature of count and state a bit out in the rain. |
|
It seems a little unnatural to refer to "count" and "state" this way, when they aren't actual variables. We could rephrase p2 in terms of having a counter, and then refer to "the counter" and "the associated state" rather than just "count" and "state". And maybe capitalise the state names, Starting etc. But I don't feel strongly about that suggestion. |
|
I fully agree that this is now somewhat unnatural. I appreciate that we don't have actual expos-only variables and that the current state is broken in that regard, but the phrasing we use only really works when talking about variables. If we're instead talking about some general concept that was introduced locally, I think the phrasing needs to be adapted. The terms are introduced in https://eel.is/c++draft/exec.run.loop.general#2: "A I think I mildly prefer the first version, but I'd like to hear other opinions. With the first version I'd also be happy to say "the instance" only once, so e.g. "The instance's count is 0 and state is starting." Thoughts? |
|
I don't love the word "instance, rather than say "the object" or "The I like "The instance's count" a lot more than just "Count". |
|
Just "the |
I don't hate it, but I don't love it either. Another option would be "The There may be no perfect answer here, we can just pick on that's better than the status quo. |
Yes, I'd be fine with that, and also don't hate it. But does it scale? Will we say that same thing for every itemdescr? |
|
@jensmaurer Could you perhaps update the PR to use that wording Jon suggested? |
Fixes NB US 231-361 (C++26 CD).
|
@tkoeppe , I've done that. |
|
I think that looks very nice, thank you! @jwakely, what do you think? |
Fixes NB US 231-361 (C++26 CD).
Fixes cplusplus/nbballot#936