TCE cebuano/tagalog web version #4805
Conversation
Bargraph6
force-pushed
the
tce-cebuano
branch
2 times, most recently
from
3818fed to
93f9400
Compare
Bargraph6
changed the title
| 'Slovenščina' => '/tce/slovenscina', | ||
| 'Türkçe' => '/tce/turkce', | ||
| 'Svenska' => '/2016/01/25/to-change-everything-in-ten-more-languages#swedish', | ||
| 'Tagalog' => '/2016/09/21/to-change-everything-in-11-more-languages#cebuano', |
There was a problem hiding this comment.
@just1602 @veganstraightedge The website mentions that the pdf is in cebuano and the video is in tagalog:
since there is no tagalog translation yet, I think it makes sense to remove this menu link and also close the taglog issue. WDYT?
Bargraph6
requested review from
astronaut-wannabe,
bookis,
eliduke,
evanphx,
guitsaru,
just1602 and
veganstraightedge
as code owners
|
@veganstraightedge @just1602 I ran through various viewport sizes in the dev tools and things look ok, so I think this is ready for a review by some fresh eyes |
| title_html: 'Sa<br />Pag-Usab<br />Sa Tanang<br />Butang' | ||
| subtitle_html: <span class="green">usa ka</span> <span class="pink">anarkistang</span> <span class="blue">pagsangpit</span> | ||
| video_cte: Tan-awa ang Video (Tagalog ang video) | ||
| video_url: https://player.vimeo.com/06b9bb22-fe01-473c-b8ba-28ef7300ba63 |
There was a problem hiding this comment.
@veganstraightedge @just1602 this video wasn't loading for me locally, but I suspect it is a localhost issue....something with CORs or something?
There was a problem hiding this comment.
I get a 404, so the video may have been removed. :/
There was a problem hiding this comment.
@just1602 the video is still available at
https://crimethinc.com/2016/09/21/to-change-everything-in-11-more-languages#cebuano
it seems like it is some sort of privacy setting on vimeo, or the url I pulled from the vimeo embed isn't usable (and someone with access to the vimeo will need to generate a new embed link)
alternatively you could re-upload the video to whatever media server you're using. I download it and have a local copy now. you can download it via yt-dlp (github doesn't let me upload as an attachment as the file is too large):
yt-dlp 'https://crimethinc.com/2016/09/21/to-change-everything-in-11-more-languages#cebuano'This creates a web version of the cebuano TCE pdf. It also removes links to a tagalog version of the PDF from the TCE menus because we do not actually have a tagalog translation yet. The website mentions that the PDF text is in cebuano, while the video is in tagalog, which is why we thought we had a tagalog pdf relates to: crimethinc#575 closes: crimethinc#1400 closes: crimethinc#1385
Bargraph6
force-pushed
the
tce-cebuano
branch
from
93f9400 to
64a2be6
Compare
2 participants
What are the relevant GitHub issues?
relates to: #575
closes: #1400
closes: #1385
What does this pull request do?
The PR adds a web version of the cebuano TCE PDF from here:
How should this be manually tested?
loading the page in various devices/screen sizes and making sure it looks ok
Is there any background context you want to provide for reviewers?
The website mentions that the pdf is in cebuano and the video is in tagalog:
so, I think it makes sense to also close the taglog issue as there is no translated PDF for that language yet
Acceptance Criteria
These should be checked by the reviewers