Add detect() method for the tab-size.js #520
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hey @drugan, builds for your detect PRs seem to be failing. Could you please take a look? |
…integral/detect/test.js
Author
|
The culprit was in test/options/integral/detect/test.js. This file uses the default csscomb.json to check options' values against but it does not have tab-size option though with the current patch the respective value is detected. Also, the logic for detect() in the tab-size.js is improved (hopefully). |
obenjiro
reviewed
Jun 11, 2017
tonyganch
force-pushed
the
dev
branch
3 times, most recently
from
359ae56 to
f05188a
Compare
Contributor
|
Hi! Me again again 😄 Would you can refresh this too? |
jdalton
force-pushed
the
dev
branch
4 times, most recently
from
f0fd8c2 to
5c69a07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reproduce:
Put mystyle.css into the project root directory.
mystyle.css.txt
Run:
csscomb -d mystyle.cssObserve:
Apply the current PR changes, run the command again and observe:
