Skip to content

Conversation

@jwilkinson87
Copy link
Contributor

This pull request refactors the FormSubmissionVersion class to improve how JSON serialization and deserialization are handled. The main change is the replacement of a locally configured Jackson ObjectMapper with a shared mapper from JsonConfig, ensuring consistent configuration across the codebase. Additionally, some minor cleanups and simplifications were made to the class.

Refactoring of JSON serialization/deserialization:

  • Replaced the local Jackson ObjectMapper with the shared mapper from JsonConfig, ensuring consistent configuration for JSON operations throughout the application. (src/main/kotlin/com/ctrlhub/core/datacapture/resource/FormSubmissionVersion.kt) [1] [2]

Code simplification and cleanup:

  • Removed redundant imports related to Jackson configuration and Kotlin module setup, as these are now handled centrally. (src/main/kotlin/com/ctrlhub/core/datacapture/resource/FormSubmissionVersion.kt)
  • Simplified the call to retrieve registered classes by removing the unnecessary Companion qualifier. (src/main/kotlin/com/ctrlhub/core/datacapture/resource/FormSubmissionVersion.kt)

@github-actions
Copy link

There is a problem with the Gemini CLI PR review. Please check the action logs for details.

@jwilkinson87 jwilkinson87 merged commit a45d2f9 into main Oct 24, 2025
2 of 3 checks passed
@jwilkinson87 jwilkinson87 deleted the fix/version-resources-hydration branch October 24, 2025 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants