feat(cubejs-client-core): add custom granularities support to drilldown() #10094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
client:core
ovr
reviewed
Oct 28, 2025
|
|
||
| if (granularity !== undefined) { | ||
| const range = dayRange(value, value).snapTo(granularity); | ||
| let range: { start: dayjs.Dayjs; end: dayjs.Dayjs }; |
There was a problem hiding this comment.
I assume that we need to tweak the dayRange function and pass timeDimensionAnnotation, because it's used in time-series, and without that, custom time dimension logic will not work.
There was a problem hiding this comment.
friendly ping to @vasilev-alex for advices here :)
…dez/cube into drill-down-custom-granularities
|
@ovr You are absolutely right! 😉 , I moved the logic to snapTo func, and also Im using now the annotations. |
KSDaemon
requested changes
Oct 29, 2025
vasilev-alex
approved these changes
Oct 31, 2025
paco-valdez
changed the title
paco-valdez
changed the title
KSDaemon
requested changes
Nov 3, 2025
| // If custom granularity has an origin, align to it | ||
| if (customGranularity.origin) { | ||
| let origin = internalDayjs(customGranularity.origin); | ||
| if (customGranularity.offset) { |
There was a problem hiding this comment.
offset and origin are mutually exclusive
|
|
||
| while (start.startOf(value).isBefore(end) || start.isSame(end)) { | ||
| results.push(start); | ||
| start = start.add(1, value); |
There was a problem hiding this comment.
How would this work for custom intervals like 3 days or 2 days 3 hours 4 minutes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Changes Made:
- Created a test case that replicates scenario with a 5-minute custom granularity
- The test verifies that drilling down returns the correct interval range
- Modified the snapTo() method to detect custom granularities using isPredefinedGranularity()
- For custom granularities:
- Predefined granularities continue to use the existing snapTo() logic