-
Notifications
You must be signed in to change notification settings - Fork 220
Fixing DDC + FES not properly reading entrypointAssetId when re-serving an app.
#4273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
PR Health |
PR HealthChangelog Entry ❗
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with |
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
| contents['entrypoint'] as String, | ||
| ); | ||
| } else { | ||
| throw Exception( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess you are throwing Exception so the stack trace doesn't get logged?
It would be maybe nicer to log.severe then return, which fails the build in the same way :) up to you.
When this happens, we read from our
.web.entrypoint.jsonfile, which would have been generated in a previous compile.