ENH: delegate create_diagonal function
#501
Open
+68
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucascolley
force-pushed
the
enh_create_diagonal
branch
from
87c4442 to
8433894
Compare
lucascolley
approved these changes
Nov 4, 2025
|
|
||
| if is_torch_namespace(xp): | ||
| return xp.diag_embed( | ||
| atleast_nd(x, ndim=1, xp=xp), offset=offset, dim1=-2, dim2=-1 |
There was a problem hiding this comment.
why do we need to use atleast_nd here, after the check above?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge request introduces the
create_diagonaldelegate function (#100).The implementation initially proposed in
array-api-extrais only partially supported by third-party backends. A branching strategy has been introduced to rely on external implementations as much as possible.Available for feedback !