-
Notifications
You must be signed in to change notification settings - Fork 833
feat: support DataType TimestampTz
#18892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5c54d41 to
7a40323
Compare
|
https://docs.snowflake.com/en/sql-reference/data-types-datetime#timestamp-ltz-timestamp-ntz-timestamp-tz
|
TimestampTimezoneTimestampTz
76c36c8 to
582708f
Compare
793d92b to
c4f3fc5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@drmingdrmer reviewed 11 of 88 files at r1, all commit messages.
Reviewable status: 11 of 88 files reviewed, 1 unresolved discussion (waiting on @KKould and @sundy-li)
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
add new DataType TimestampTz, Used to record time zone offset based on Timestamp. Timestmap times in different time zones can exist in the same column.
example:
TODO:
Tests
Type of change
This change is