Skip to content

Conversation

@deepcodeg
Copy link
Owner

No description provided.

@deepcodeappdev
Copy link

deepcodeappdev bot commented May 6, 2020

DeepCode's analysis on #0ed24b found:

  • 2 critical issues. ⚠️ 2 warnings 2 minor issues. ✔️ 0 issues were fixed.
  • We show critical issues and security vulnerabilities below 👇.

List of critical issues

Description of the issue ❌ Example fixes
compare does not return -1, but needs to. The implementer must ensure sgn(x.compare(y)) == -sgn(y.compare(x)) for all x and y. Occurrences: Example fixes 🔧
The usage of regex in replace will change only the first match. Consider using a regular expression with the global replacement flag (/g). Occurrences: Example fixes 🔧


👉 View analysis in DeepCode’s Dashboard

☺️ If you want to provide feedback on our bot, here is how to contact us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants