Skip to content

Conversation

@challiwill
Copy link

@challiwill challiwill commented May 30, 2025

@challiwill challiwill marked this pull request as ready for review June 2, 2025 20:44
This feels more expected to me, otherwise if you ask for connected peripherals a second time you will not get alerts for the previously found peripherals.
@pyang2045
Copy link

@challiwill It appears this PR doesn’t have a reviewer yet

@challiwill
Copy link
Author

@pyang2045 That's correct. I was hoping to get feedback from @qdot following the conversation in issue #259, but I figure we've all been busy with other commitments.

@szymonlesisz
Copy link
Contributor

im not sure if retrieved connected peripherals should be treated as discovered.

i've played around this for a little bit and from my experience on macos if device is connected to another app you cant really use it, like for example disconnect it and im pretty sure i had some issues with writing or reading from it.
i guess this is the reason why corebluetooth is hiding it from the scan results.

with your changes it would act as it is discovered, connected and ready to go.

similar case is with retrieving peripherals by identifiers
if device is known (paired) but it is not advertising it will also not be visible in scan results.

instead i'm proposing less platform-specific approach and create Adapter.retrieve_peripherals() with options (by services, by identifiers, ...by other_future_params)

what dou you think? @qdot? @qwandor?

Copilot AI review requested due to automatic review settings October 31, 2025 08:37
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@qwandor qwandor changed the base branch from master to dev November 2, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants