-
-
Notifications
You must be signed in to change notification settings - Fork 179
Retrieve connected devices #437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
This feels more expected to me, otherwise if you ask for connected peripherals a second time you will not get alerts for the previously found peripherals.
|
@challiwill It appears this PR doesn’t have a reviewer yet |
|
@pyang2045 That's correct. I was hoping to get feedback from @qdot following the conversation in issue #259, but I figure we've all been busy with other commitments. |
|
im not sure if retrieved connected peripherals should be treated as discovered. i've played around this for a little bit and from my experience on macos if device is connected to another app you cant really use it, like for example disconnect it and im pretty sure i had some issues with writing or reading from it. with your changes it would act as it is discovered, connected and ready to go. similar case is with retrieving peripherals by identifiers instead i'm proposing less platform-specific approach and create Adapter.retrieve_peripherals() with options (by services, by identifiers, ...by other_future_params) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
#259