Skip to content

Conversation

@melak
Copy link

@melak melak commented Sep 21, 2024

FreeBSD #defines several stdio macros the same way OpenBSD does. Extend the scope of the existing special case to FreeBSD as well, and generalize the comment (in anticipation of it needing to be extended).

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

FreeBSD #defines several stdio macros the same way OpenBSD does.
Extend the scope of the existing special case to FreeBSD as well,
and generalize the comment (in anticipation of it needing to be
extended).
@tautschnig
Copy link
Collaborator

Yes, I’m aware of that problem, and proposed a somewhat more comprehensive fix in #8043 - @kroening any thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants