Skip to content

Conversation

@mohammed-io
Copy link
Contributor

@mohammed-io mohammed-io commented Sep 26, 2024

  • Supporting Rails 7.2
  • Dropping Ruby 2 support in Rubocop and Gemspec (3.0.0 is minimum now)

spec.require_paths = ['lib']

spec.add_runtime_dependency 'activesupport', '>= 6.0', '< 7.2'
spec.add_runtime_dependency 'activesupport', '>= 6.0', '< 7.3'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The next version will be 8.0 tho.

@mohammed-io
Copy link
Contributor Author

@marcqualie looks like one issue left for the test

            /opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/3.0.0/rubygems/resolver/molinillo/lib/molinillo/resolution.rb:317:in `raise_error_unless_state': Unable to satisfy the following requirements: (Gem::Resolver::Molinillo::VersionConflict)
            
            - `activesupport (= 7.2.1)` required by `user-specified dependency`
            - `activesupport (>= 5.0.0)` required by `rails-dom-testing-2.2.0`
            ```

@mohammed-io mohammed-io marked this pull request as draft September 26, 2024 13:01
@mohammed-io mohammed-io marked this pull request as ready for review September 26, 2024 13:01
@mohammed-io
Copy link
Contributor Author

I though some of errors due to Ruby version mismatch. It looks like it didn't fix the issue. Should I revert the version change?

AllCops:
NewCops: enable
TargetRubyVersion: 2.6
TargetRubyVersion: 3.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
TargetRubyVersion: 3.0
TargetRubyVersion: 2.6

Rakefile Outdated

path = File.expand_path(__dir__)
Dir.glob("#{path}/lib/diffcrypt/tasks/**/*.rake").sort.each { |f| load f }
Dir.glob("#{path}/lib/diffcrypt/tasks/**/*.rake").each { |f| load f }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Dir.glob("#{path}/lib/diffcrypt/tasks/**/*.rake").each { |f| load f }
Dir.glob("#{path}/lib/diffcrypt/tasks/**/*.rake").sort.each { |f| load f }

spec.homepage = 'https://github.com/diffcrypt/diffcrypt-ruby'
spec.license = 'MIT'
spec.required_ruby_version = Gem::Requirement.new('>= 2.6.0')
spec.required_ruby_version = Gem::Requirement.new('>= 3.0.0')
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
spec.required_ruby_version = Gem::Requirement.new('>= 3.0.0')
spec.required_ruby_version = Gem::Requirement.new('>= 2.6.0')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants