Framing - reset graph context after recursing through named graphs #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, If you have a chance could you provide a test example? I'll try to get it into main json-ld.org test suite to avoid the same issue in other implementations. If you want to add a patch to that repo, that works too. Thanks, and apologies for the late response. |
|
sure - i may already have one in some of the posts i put on the WG issues list, e.g. this. I'm traveling this week but i'll try and put something together soon. |
This was referenced Jun 29, 2018
|
Should this be merged since json-ld/json-ld.org#663 is merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When framing a JSON-LD document with at least one named graph, the current graph (
state['graph']) was not being reset after recursing through the named graphs. Since the code iterates in alphabetical order, this only manifested for objects in the default graph that had@ids greater than the@idof the first named graph. This would be a good test to put into the overall JSON-LD framing test suite, please let me know if you want a formal example.