Fix assets not being saved in exporter #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One important change, PrefabEditor doesn't return both GameObjects and ScriptableObjects anymore, as I could not find any info online about ScriptableObjects being prefabs. You can use them in a prefab, but they are not prefabs themselves. (Also it fit with the generic refactor in BaseSettingsAssetEditor.GetAssetPaths) |
Fixes a small bug where the editor and exporter had different opinions on what a mod contained
Also reflect these changes in methods using them
Also refactor BaseAssetEditor.GetAssetPaths usage to be more generic
burnedram
force-pushed
the
burnedram-exportsettings-refactor
branch
from
4ed87c6 to
d186a37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also refactor some "untyped" assets in ExportSettings (they were UnityEngine.Objects) to reflect their actual type.
And I noticed that ArtifactEditor wasn't in the GUI. If it's not ready yet I can just remove that commit.