[Xamarin.Android.Build.Tasks] don't set $(UseMonoRuntime) by default
#10527
+3,526
−326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanpeppers
force-pushed
the
dev/peppers/usemonoruntime
branch
from
ad0ed28 to
c9bb3bb
Compare
|
I assume this means that in .NET 11 CoreCLR will be the default runtime… |
grendello
force-pushed
the
dev/peppers/usemonoruntime
branch
4 times, most recently
from
dbf485e to
8000aef
Compare
| <_AndroidRuntime Condition=" '$(PublishAot)' == 'true' and '$(UseMonoRuntime)' != 'true' ">NativeAOT</_AndroidRuntime> | ||
| <_AndroidRuntime Condition=" '$(PublishAot)' != 'true' and '$(UseMonoRuntime)' != 'true' ">CoreCLR</_AndroidRuntime> | ||
| <_AndroidRuntime Condition=" '$(_AndroidRuntime)' == '' ">MonoVM</_AndroidRuntime> | ||
| <_AndroidRuntime Condition=" '$(PublishAot)' == 'true' ">NativeAOT</_AndroidRuntime> |
There was a problem hiding this comment.
What happens in Debug builds when you have <PublishAot>true</PublishAot> in the project file? Does it try to still run with NativeAOT? For "PublishAOT Debug builds", I believe we need to use CoreCLR 🤔 I suppose we can fix that later though.
There was a problem hiding this comment.
I think in this case it will try to use Mono AOT as it is now, at least the error messages I've seen suggest that. Yeah, we can't use NativeAOT for debug builds.
There was a problem hiding this comment.
Let's address this in another PR, I think Debug mode should mirror what a console app does. It would use CoreCLR there.
grendello
force-pushed
the
dev/peppers/usemonoruntime
branch
2 times, most recently
from
0ead24b to
3492e3f
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
grendello
force-pushed
the
dev/peppers/usemonoruntime
branch
2 times, most recently
from
a55d6f6 to
dae743f
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
grendello
force-pushed
the
dev/peppers/usemonoruntime
branch
from
dae743f to
23a5d24
Compare
|
/azd run |
grendello
force-pushed
the
dev/peppers/usemonoruntime
branch
from
a4ea6e9 to
da832e4
Compare
The removed classes contain tests which fail on CoreCLR (possibly due to not supporting the managed typemap, but it requires more research) and should be fixed in a separate PR.
grendello
force-pushed
the
dev/peppers/usemonoruntime
branch
from
da832e4 to
0d9b143
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make CoreCLR the default runtime.
Fixes or (temporarily) disables a number of tests which were failing because of a variety
of reasons, such as:
Additionally, it parametrizes a number of tests with the runtime type,
so that they ran for both MonoVM and CoreCLR (and, eventually, NativeAOT)